Armitage Archive

Code Reviews at Medium

by Christine Donovan

Original article

This page contains highlights I saved while reading Code Reviews at Medium by Christine Donovan. These quotes were collected using Readwise.

Highlights

We also value the Reasonable Person Principle. It's pretty self-explanatory; it's about starting with the assumption that another person is acting from reasonable intentions. This principle reminds us to see each other as humans first, and be generous in our interpretations of one another.

Permalink to this highlight


We also think it's useful to look over your pull request, and see if there are places where someone might ask, "Why did this need to change?" An engineer can consider adding preemptive comments in Github

Permalink to this highlight


PTAL stands for Please Take A Look or Please Take Another Look. When this comment is added, our Slack integration tool will send a notification to all reviewers. The notification will tell them that the author is asking them to "please take another look."

Permalink to this highlight


We want to break our code down as much as possible and submit small, digestible PRs. By doing this, we can review quicker and move faster.

Permalink to this highlight


Want more like this? See all articles or get a random quote.