Armitage Archive

Highlight from Mistakes I See Engineers Making in Their Code Reviews

An approval should mean “I’m happy for you to merge, even if you ignore my comments”. Just leaving comments should mean “I’m happy for you to merge if someone else approves, even if you ignore my comments.”